-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove plugin search feature #14759
Remove plugin search feature #14759
Conversation
266de1d
to
72ac7d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love changes like this that remove features as a maintainer, thank you. (One nits)
Co-authored-by: SUZUKI Sosuke <aosukeke@gmail.com>
Reply to your question in discord about "global installation". I don't have a good answer for that, they'll have to run or alias |
@fisker maybe there could be some solution offered on the editor extension level. I believe that a global Prettier setup with plugins is mainly needed in somewhat non-standard environments like in education. For example, prettier-plugin-elm is used with litvis for teaching data visualisation:
In general, I am supportive of plugin search removal – this feature is really hard to implement for all package managers and various modes within them. We just need to be aware of us breaking certain valid use cases and be ready to offer a new solution for them. Perhaps, folks who do rely on global plugin search and can’t easily use |
Is there a possibility that this pull request could resolve the hoisting issue in pnpm? |
Hi, I'm trying to understand the impact of this change for my plugin. Does this mean that I should ask all of my users to edit their Prettier config file to include something like:
or change their CLI call to include:
If that is the case, I can already foresee the amount of tickets opened in my project because of this 😭 . I haven't followed upstream development closely recently, my assumption is that this will only be in Prettier v3 and above, not v2 right? |
Correct. |
Co-authored-by: SUZUKI Sosuke <aosukeke@gmail.com>
Description
Closes #14652
Closes #8056
Closes #9167
Closes #13583
Closes #8474
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨