Add test cases about code embedding in markdown that relates to #15909 #15985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you put these code blocks in separate files and make them "ugly" first? |
|
OK. Does "making them ugly" mean make inputs ugly keeping AST? Or emphasize bug in output tweaking AST? |
You can just put two extra lines on top, since we silently fail on embed format, it's not clear the code block is formatted or not. |
|
@fisker |
fisker
approved these changes
Jan 26, 2024
|
Great! Thank you! |
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15909 (comment)
Now I'm sure that every diff shown in prettier/prettier-regression-testing#435 (comment) is bug fix.
Description
Checklist
I’ve added tests to confirm my change works.(If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/directory).(If the change is user-facing) I’ve added my changes tochangelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨