-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(markdown): add proseWrap: "preserve"
option
#3340
Merged
azz
merged 12 commits into
prettier:master
from
ikatyang:feat/markdown-preserve-prose-wrap
Dec 1, 2017
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2182839
test: add test case
ikatyang 7996195
feat(markdown): add `proseWrap: "preserve"` option
ikatyang 5d33de2
test: add tests
ikatyang 666a813
docs(options): update `proseWrap`
ikatyang 54e0b36
Merge branch 'master' into feat/markdown-preserve-prose-wrap
ikatyang 8425da1
feat(markdown): change default to `proseWrap: "preserve"`
ikatyang 0ad1167
docs(options): update `proseWrap`
ikatyang ad17d05
test: specify option explicitly
ikatyang d81d1e4
Merge branch 'master' into feat/markdown-preserve-prose-wrap
ikatyang 6de9e61
Merge branch 'master' into ikatyang-feat-markdown-preserve-prose-wrap
duailibe 119a23e
Fix lint after merge
duailibe 287aa5f
Fix error after merge
duailibe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
run_spec(__dirname, { parser: "markdown" }); | ||
run_spec(__dirname, { parser: "markdown", proseWrap: false }); | ||
run_spec(__dirname, { parser: "markdown", proseWrap: "never" }); | ||
run_spec(__dirname, { parser: "markdown", proseWrap: "preserve" }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
Hic dicta et recusandae incidunt. Reiciendis saepe voluptatem tempore rem aut. | ||
Iusto sapiente impedit. Laudantium ut id non et aperiam ab. | ||
|
||
Sit minus architecto quas quibusdam sed ipsam aut eum. | ||
Dolores tempora reiciendis magni blanditiis laborum aliquid rem corporis enim. Et consectetur quo sed excepturi soluta repudiandae commodi id. | ||
Eum possimus optio distinctio incidunt quasi optio culpa accusamus. | ||
Architecto esse ut aut autem ullam consequatur reiciendis aliquid dolorum. | ||
|
||
Et quam mollitia velit iste enim exercitationem nemo. | ||
Hic dignissimos eos et. Eos eos consequatur. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still use
deprecated.js
? It seems to be outdated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it's only used for
useFlowParser
warning.I think we can refactor those option warnings/redirections using #3352.