Fix PostCSS VS Code integration #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ardevelop, while I think I understand what's this supposed to fix, could you add a description of what exactly is the problem you are facing and why this fixes it? Thanks for the PR! :) |
|
@duailibe thanks for feedback, updated description, PTANL |
|
Thanks for updating @ardevelop! @azz what do you think? |
|
What does postcss as a language actually mean? |
azz
approved these changes
Dec 14, 2017
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PostCSS integration for VS Code
Extension (prettier-vscode) is querying prettier for supported languages, and is not getting any information about
postcss. As a result engineer sees that is no any formatter forpostcss:After exposing information that prettier supports
postcsseverything works fine.