Break JSX element if a string literal prop has a newline #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
approved these changes
Feb 20, 2018
suchipi
approved these changes
Feb 20, 2018
|
You might want to review it again, it didn't fix all the cases before :) |
j-f1
requested changes
Feb 20, 2018
| <path | ||
| d="M4.765 16.829l3.069-2.946 5.813 5.748 | ||
| 11.33-11.232 3.006 3.18-14.36 14.080z" | ||
| />; |
There was a problem hiding this comment.
Shouldn’t this end up on the same line since jsxBracketSameLine is true?
There was a problem hiding this comment.
Nope
Prettier 1.10.2
Playground link
--jsx-bracket-same-lineInput:
<C
propA="longlonglonglonglonglonglonglonglong"
propB="longlonglonglonglonglonglonglonglong"
/>;Output:
<C
propA="longlonglonglonglonglonglonglonglong"
propB="longlonglonglonglonglonglonglonglong"
/>;That is meant to be visually similar to
<Parent>
<Child />
</Parent>There was a problem hiding this comment.
Oh OK so it’s only inlined if it’s an opening element.
j-f1
approved these changes
Feb 20, 2018
lipis
added a commit
to lipis/prettier
that referenced
this pull request
Feb 22, 2018
* 'master' of github.com:prettier/prettier: Add ComputerBase to list of users (prettier#4027) refactor: at rules parse (prettier#4023) refactor(css): printer (prettier#4024) Webstorm now supports Prettier (prettier#4026) Handle definite variable declarations (prettier#4025) fix(css): comments in at rules (prettier#3920) feat(typescript): support definite assignment (`!:`) (prettier#4020) Add support for markdown with pre-commit (prettier#4021) Remove extraneous newline in docs/plugins.md Break JSX element if a string literal prop has a newline (prettier#4011) Add license to website/package.json (prettier#4017) Add Ruby to homepage and code (prettier#4016) Add Google Site Verification file (prettier#4015)
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3803