Allow new interface style for GraphQL. #4012
Conversation
| try { | ||
| return parse(source, { allowLegacySDLImplementsInterfaces: false }); | ||
| } catch (_) { | ||
| return parse(source, { allowLegacySDLImplementsInterfaces: true }); |
There was a problem hiding this comment.
It'd be great if we could detect which style the code was originally written so we could support both styles, and we can with this code.
But I don't think it's worth the trouble though.
There was a problem hiding this comment.
I would agree with that.
|
Will users on older versions of GraphQL libraries be inconvenienced if prettier starts using the new style? As in, will their libraries not be able to parse the new |
|
Yes, I would consider this change a breaking change and consumers should be made aware. If you disagree and think that we should support it regardless, I would ask for your suggestions on how to do it since the AST provided does not include any notion of separator. |
|
We have to check the source ( |
This is a breaking change since it will upgrade the old style to the new one. Closes prettier#3600.
When in present of mixed style, it updates to the new one.
ruiaraujo
force-pushed
the
update_graphql
branch
from
4b72949
to
356db5e
Compare
|
Should I worry about the codecov/project check? |
|
Nah |
lock
bot
added
the
locked-due-to-inactivity
This is a breaking change since it will upgrade the old style to the new one.
Closes #3600.