Add support for flow explicit type arguments #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duailibe
approved these changes
May 24, 2018
suchipi
approved these changes
May 25, 2018
existentialism
added a commit
that referenced
this pull request
May 25, 2018
We landed a change that added a new `InterpreterDirective` AST node type for hashbangs, and no longer add it as a comment/leadingComment. Ref: babel/babel#7928 I mimicked what we do in `@babel/generator` here, since I found it better than trying to add comments to the ast in `parser-include-shebang.js`). Definitely open to a better/cleaner option though! Note: I'll follow this up with enabling tests for #4543 and #4540 once they land too.
duailibe
reviewed
May 27, 2018
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| //@flow | ||
| f<T>(); | ||
| f < T > <U />; |
There was a problem hiding this comment.
@existentialism Is this right?
There was a problem hiding this comment.
Yep, AFAIK, it makes sure it's JSX, here's associated parser test:
https://github.com/babel/babel/tree/master/packages/babel-parser/test/fixtures/flow/typeapp-call/rollback-jsx
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4489.
Babylon support landed in
beta.48just now but requires a few other fixture changes, so I'm going to follow this up with another PR.