Add support for flow inline interfaces #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchipi
approved these changes
May 25, 2018
alexander-akait
approved these changes
May 25, 2018
duailibe
approved these changes
May 25, 2018
j-f1
reviewed
May 25, 2018
src/language-js/printer-estree.js
Outdated
| @@ -2485,6 +2485,26 @@ function printPathNoParens(path, options, print, args) { | |||
| path.call(print, "id"), | |||
| path.call(print, "typeParameters") | |||
| ]); | |||
|
|
|||
| case "InterfaceType": | |||
| case "InterfaceTypeAnnotation": { | |||
There was a problem hiding this comment.
Is there any way to combine this with the TS one?
There was a problem hiding this comment.
I was hesitant initially, since they can't have an id or typeParameters, but I went ahead and merged it with the logic for printing flow's DeclareInterface and InterfaceDeclaration.
existentialism
force-pushed
the
flow-inline-interface
branch
from
fec99c5
to
a623d04
Compare
existentialism
added a commit
that referenced
this pull request
May 25, 2018
We landed a change that added a new `InterpreterDirective` AST node type for hashbangs, and no longer add it as a comment/leadingComment. Ref: babel/babel#7928 I mimicked what we do in `@babel/generator` here, since I found it better than trying to add comments to the ast in `parser-include-shebang.js`). Definitely open to a better/cleaner option though! Note: I'll follow this up with enabling tests for #4543 and #4540 once they land too.
Merged
lock
bot
added
the
locked-due-to-inactivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow commit: facebook/flow@4f93f3a
Babel commit: babel/babel#7973
Will follow up w/ flow team on making
InterfaceType->InterfaceTypeAnnotation, since it seems a bit inconsistent.