Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type only import/export via babel-ts #7804

Merged
merged 3 commits into from
Mar 21, 2020

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Mar 20, 2020

Babel 7.9.0 has been released! It supports TypeScript 3.8 type only import/export.

But, we cannot update snapshots now, because there is babel/babel#11291. We need to wait the issue is fixed.

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@@ -2,7 +2,6 @@ export type { SomeThing };
export type { A as B };
export type { B as C } from './a';
export type { foo } from 'bar';
export type * from 'bar';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosukesuzuki sosukesuzuki changed the title [wip] Support type only import/export via babel-ts Support type only import/export via babel-ts Mar 21, 2020
@sosukesuzuki sosukesuzuki marked this pull request as ready for review March 21, 2020 15:06
@thorn0 thorn0 merged commit 20c7a5a into prettier:next Mar 21, 2020
@sosukesuzuki sosukesuzuki deleted the babel-7.9.0 branch March 21, 2020 15:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants