Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add two plugins pkg and sh #8138

Merged
merged 1 commit into from
May 6, 2020
Merged

docs: add two plugins pkg and sh #8138

merged 1 commit into from
May 6, 2020

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 23, 2020

prettier-plugin-pkg for package.json
prettier-plugin-sh for shell scripts

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

`prettier-plugin-pkg` for `package.json`
`prettier-plugin-sh` for shell scripts
@fisker
Copy link
Member

fisker commented Apr 23, 2020

I think we should add some descriptions to these plugins. I mean all plugins.

@thorn0 @evilebottnawi

@thorn0
Copy link
Member

thorn0 commented Apr 23, 2020

@fisker Agree. This list probably needs to be turned into a table.

@kachkaev
Copy link
Member

Should the plugins be inserted so that the list remained alphabetical?

@lipis
Copy link
Member

lipis commented May 5, 2020

Yes I agree that we have to turn this thing into a table.. but in a separate PR..

Some suggestions for the columns:

  • Name
  • Description
  • AST (if it's changing the AST or not)
  • Additional options
  • (Anything else?)

@lipis lipis merged commit 736db9b into prettier:master May 6, 2020
@JounQin JounQin deleted the patch-1 branch May 6, 2020 14:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants