Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript: Break ternary expressions containing a multi-line block comment #8592

Merged
merged 2 commits into from
Jun 21, 2020
Merged

JavaScript: Break ternary expressions containing a multi-line block comment #8592

merged 2 commits into from
Jun 21, 2020

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jun 18, 2020 •
edited
Loading

Fixes #8556

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

fisker
fisker approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sosukesuzuki sosukesuzuki merged commit 0213706 into prettier:master Jun 21, 2020
@sosukesuzuki sosukesuzuki deleted the 8556 branch June 21, 2020 08:03
@sosukesuzuki
Copy link
Member Author

@thorn0 I merged because this PR got two approves but if you notice any problem please let me know.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fisker fisker fisker approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@thorn0 thorn0 Awaiting requested review from thorn0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript: incorrecct formatting for multiline block comments after ternary "?"
3 participants
@sosukesuzuki @fisker @alexander-akait