-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handlebars: Do not format html element attributes but class
#8677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should the attribute case insensitive? Prettier pr-8677 --parser glimmer Input: <A CLASS=" foo bar
"></A>
<A class=" foo bar
"></A> Output: <A CLASS=" foo bar
" />
<A class="foo bar,[object Object]" /> Prettier pr-8677 --parser html Input: <A CLASS=" foo bar
"></A>
<A class=" foo bar
"></A> Output: <a class="foo bar"></a> <a class="foo bar"></a> |
fisker
approved these changes
Jul 3, 2020
alexander-akait
approved these changes
Jul 3, 2020
3 tasks
@prettier/core Need review. |
@dcyriller @fisker anything I can help with to get this merged? It's blocking the other PR that's also good to go. |
thorn0
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stops formatting every html attributes for handlebars. Only class names will be formatted. This was breaking browser rendering and is considered a bug.
This would address #8667 (comment) (100% agreed).
TODO:
style
andsrcset
attributes later (similar to what html does).Checklist
docs/
directory)changelog_unreleased/*/pr-XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨