Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(markdown): option to disable printing spaces between Chinese / Japanese and others #9138

Closed
wants to merge 1 commit into from

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Sep 3, 2020

Based on #8526 (Thanks to @rdrgn)

Differences from #8526:

  • Don't touch on Hangul.
  • Change option name & type & description.

To do:

  • Deal with proseWrap
  • Add test cases for proseWrap

I want this program to warn me to specify this option when the system locale is Chinese or Japanese and this option is not explicitly specified. How do I do this?

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

description: outdent`
Insert spaces wherever between Chinese or Japanese and non-CJK.
`,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read answer in the issue

…Japanese and others Based on prettier#8526 (Thanks to @rdrgn) Differences from prettier#8526: - Don't touch on Hangul. - Change option name & type & description.
@tats-u
Copy link
Contributor Author

tats-u commented Sep 6, 2020

Since adding new options is not allowed, I will try to solve the issues with a different way (including pre-processing).

@tats-u tats-u closed this Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants