-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handlebars: Print final blockParam on its own line #9978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcyriller
force-pushed
the
has-block
branch
2 times, most recently
from
December 30, 2020 16:21
e945d83
to
e2a80ac
Compare
fisker
approved these changes
Dec 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@dcyriller Can you fix the conflicts? |
done ✅ |
sosukesuzuki
approved these changes
Jan 12, 2021
kurtinatlanta
added a commit
to kurtinatlanta/prettier
that referenced
this pull request
Jan 17, 2021
* master: (48 commits) Refactor: Use getLastStatement function in printStatementSequence (prettier#10066) Build(deps): Bump meriyah from 3.1.6 to 4.0.0 (prettier#10060) Add meriyah to getMarkdownSyntax (prettier#10061) Build(deps): Bump @angular/compiler from 11.0.8 to 11.0.9 (prettier#10055) Build(deps-dev): Bump webpack from 5.13.0 to 5.14.0 in /website (prettier#10053) Build(deps-dev): Bump webpack from 5.13.0 to 5.14.0 (prettier#10054) Build(deps-dev): Bump eslint-plugin-unicorn from 26.0.0 to 26.0.1 (prettier#10056) handlebars: Print final blockParam on its own line (prettier#9978) Build(deps-dev): Bump webpack from 5.12.3 to 5.13.0 (prettier#10040) Enable `unicorn/prefer-regexp-test` (prettier#10045) Build(deps-dev): Bump @typescript-eslint/types from 4.12.0 to 4.13.0 (prettier#10038) Build(deps): Bump @typescript-eslint/typescript-estree from 4.12.0 to 4.13.0 (prettier#10039) Build(deps-dev): Bump eslint-plugin-unicorn from 25.0.1 to 26.0.0 (prettier#10042) Build(deps): Bump @angular/compiler from 11.0.7 to 11.0.8 (prettier#10041) Build(deps-dev): Bump webpack from 5.12.3 to 5.13.0 in /website (prettier#10037) Build(deps-dev): Bump @types/estree from 0.0.45 to 0.0.46 (prettier#10043) Build(deps-dev): Bump terser-webpack-plugin from 5.0.3 to 5.1.1 (prettier#10033) Build(deps-dev): Bump webpack from 5.11.1 to 5.12.3 (prettier#10035) Build(deps-dev): Bump webpack from 5.11.1 to 5.12.3 in /website (prettier#10034) Refactor: Use `Doc[]` instead of `concat()` (prettier#9993) ... # Conflicts: # package.json # src/language-js/printer-estree.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the change proposed in #8502.
Given these options:
Input:
Current Output:
Proposal:
cc @pzuraq
Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨