pointsToCost performance improvement

Improve the performance of `pointsToCost` by doing a two-level lookup instead of a single lookup using a concatenated string.
prettymuchbryce · Mar 31, 2017 · 77e6140 · 77e6140
1 parent befb8c6
commit 77e6140
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/easystar.js b/src/easystar.js
@@ -119,7 +119,10 @@ EasyStar.js = function() {
     * @param {Number} The multiplicative cost associated with the given point.
     **/
     this.setAdditionalPointCost = function(x, y, cost) {
-        pointsToCost[x + '_' + y] = cost;
+        if (pointsToCost[y]===undefined) {
+            pointsToCost[y] = {};
+        }
+        pointsToCost[y][x] = cost;
     };
 
     /**
@@ -129,7 +132,9 @@ EasyStar.js = function() {
     * @param {Number} y The y value of the point to stop costing.
     **/
     this.removeAdditionalPointCost = function(x, y) {
-        delete pointsToCost[x + '_' + y];
+        if (pointsToCost[y]) {
+            delete pointsToCost[y][x];
+        }
     }
 
     /**
@@ -491,7 +496,7 @@ EasyStar.js = function() {
     };
 
     var getTileCost = function(x, y) {
-        return pointsToCost[x + '_' + y] || costMap[collisionGrid[y][x]]
+        return (pointsToCost[y] && pointsToCost[y][x]) || costMap[collisionGrid[y][x]]
     };
 
     var coordinateToNode = function(instance, x, y, parent, cost) {