Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #43 (add ci) #86

Closed
wants to merge 4 commits into from

Conversation

esromneb
Copy link
Contributor

This adds a travis.yml config. In order to get this to work you need to go to https://travis-ci.com/ and make a free account with your github. When they ask for access, just give them access to easystarjs repo. After that you will be able to do builds with each commit.
If you want to see the what the builds on my fork look like, see here: https://travis-ci.com/github/esromneb/easystarjs
I've added builds for version 8-14 as well as node. It seems like something in karma doesn't work in node 15 right now.
After you make your account, go to your build page on travis-ci.com click on the "build passing" badge. Select format of "markdown" and then paste that into the top of your README.md. this will add a badge to your project.

@esromneb esromneb mentioned this pull request Oct 28, 2020
@esromneb esromneb changed the title Fix for Issue #43 Fix for Issue #43 (add ci) Oct 28, 2020
@prettymuchbryce
Copy link
Owner

Thanks for your contribution! Is there a reason why we should use travis-ci over GitHub Actions? I think the original issue was created before this feature existed natively in GitHub.

@esromneb
Copy link
Contributor Author

esromneb commented Oct 28, 2020

No reason. I will re-do this with github actions and then re-submit within the next 2 days. Feel free to reject this one now.

@prettymuchbryce
Copy link
Owner

Thanks. Sorry for the confusion. This project is definitely due for some issue / PR cleanup. 😖

@esromneb
Copy link
Contributor Author

No problem, I am happy to contribute. This project is allowing me to make my dream RTS (slowly). Maybe I'll finish one day! Thanks again

@esromneb esromneb closed this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants