수정 : 로그인 인증 예외 핸들러 적용 및 JWT 예외 반환 로직 수정 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hejow
approved these changes
Oct 9, 2023
Comment on lines
77
to
78
| public void validateToken(String token) { | ||
| Jwts.parserBuilder().setSigningKey(key).build().parseClaimsJws(token); |
There was a problem hiding this comment.
코드가 이렇게 수정되면 더 이상 validateToken 네이밍은 아닐 것 같은데 어떻게 생각하시나용!??
There was a problem hiding this comment.
140ef5f 피드백 반영
- 파싱 메소드 자체가 좀 중복되어어서 로직을 변경하였습니다.
- 해당 메소드는 삭제하였고 parseClaims 메소드에서 일괄적으로 수행합니다 !
| @ResponseStatus(UNPROCESSABLE_ENTITY) | ||
| public ErrorResponse handleUnexpectedException(BadCredentialsException e) { | ||
| log.warn("BadCredentialException Occurs : {}", e.getMessage()); | ||
| public ErrorResponse handleUnexpectedException(AuthenticationException e) { |
There was a problem hiding this comment.
0aff2bd 커밋 피드백 반영
- 앗 메소드 네이밍 수정하였습니다 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 어떤 PR인가요?
😋 To Reviewer