[NAYB-157] feat: 점원은 주문을 확인하고 배달을 생성할 수 있다. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4-NaBMart into feature/NAYB-157
hseong3243
requested review from
pushedrumex,
funnysunny08,
seongHyun-Min,
Seongju-Lee and
bjo6300
as code owners
bjo6300
approved these changes
Sep 21, 2023
|
|
||
| public class AlreadyRegisteredDeliveryException extends DeliveryException { | ||
|
|
||
| public AlreadyRegisteredDeliveryException(String message) { |
There was a problem hiding this comment.
Suggested change
| public AlreadyRegisteredDeliveryException(String message) { | |
| public AlreadyRegisteredDeliveryException(final String message) { |
|
|
||
| public record FindPayedOrdersRequest( | ||
| @PositiveOrZero(message = "페이지 번호는 음수일 수 없습니다.") | ||
| Integer page) { |
There was a problem hiding this comment.
Integer이면 null 값도 들어올 수 있으니 @NotNull을 검증하시는거 어떠신가요??
There was a problem hiding this comment.
생성자에서 page에 대한 기본값을 정의해주고 있어서 따로 넣지는 않았습니다!
|
|
||
| public class UnauthorizedOrderException extends OrderException { | ||
|
|
||
| public UnauthorizedOrderException(String message) { |
There was a problem hiding this comment.
Suggested change
| public UnauthorizedOrderException(String message) { | |
| public UnauthorizedOrderException(final String message) { |
| public static FindPayedOrdersResponse of( | ||
| List<Order> orders, | ||
| int page, | ||
| long totalElements) { |
There was a problem hiding this comment.
Suggested change
| long totalElements) { | |
| final long totalElements) { |
|
|
||
| public record FindPayedOrdersCommand(Long userId, int page) { | ||
|
|
||
| public static FindPayedOrdersCommand of(Long userId, int page) { |
There was a problem hiding this comment.
Suggested change
| public static FindPayedOrdersCommand of(Long userId, int page) { | |
| public static FindPayedOrdersCommand of(final Long userId, final int page) { |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
Employee권한을 추가하였습니다.Order의 상태를 PAYED에서 DELIVERING으로 변경합니다.📝 작업 요약
💡 관련 이슈