Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --target-branch flag from NPM beta publish workflow #1178

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

craigpalermo
Copy link
Collaborator

@craigpalermo craigpalermo commented Aug 4, 2022

From the Rush docs:
image

Removing that flag prevents the changes to package.json from being committed back to the branch.

@craigpalermo craigpalermo temporarily deployed to Production August 4, 2022 14:32 Inactive
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1178 (b1e0769) into main (dcec77b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1178   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files         176      176           
  Lines        2398     2398           
  Branches      545      545           
=======================================
  Hits         2288     2288           
  Misses         58       58           
  Partials       52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@craigpalermo craigpalermo changed the title Fake change Remove --target-branch flag from NPM beta publish workflow Aug 4, 2022
@craigpalermo craigpalermo marked this pull request as ready for review August 4, 2022 14:42
@craigpalermo craigpalermo merged commit 65fb037 into main Aug 4, 2022
@craigpalermo craigpalermo deleted the test-beta-publishing branch August 4, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants