Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StaticMessage: support severity "success" #11375

Closed
jepsar opened this issue Feb 2, 2024 · 5 comments · Fixed by #11901
Closed

StaticMessage: support severity "success" #11375

jepsar opened this issue Feb 2, 2024 · 5 comments · Fixed by #11901
Assignees
@melloware
Labels
new feature
Milestone
15.0.0

Comments

@jepsar
Copy link
Member

jepsar commented Feb 2, 2024

Description

It now shows the component unstyled.

Describe the solution you would like

Show in green with checkmark icon.

Additional context

Maybe throw an exception if the severity is not supported.
@jepsar jepsar self-assigned this Feb 2, 2024
@jepsar jepsar added this to the 15.0.0 milestone Feb 2, 2024
@tandraschko
Copy link
Member

currently there is no success severity in JSF

@tandraschko
Copy link
Member

see jakartaee/faces#1592

@jepsar
Copy link
Member Author

jepsar commented Feb 2, 2024

Yeah, but you can use any string in this component. It's not restricted to FacesMessages.

@melloware
Copy link
Member

we could add it just for static message since its just a string. Plus I can update the themes with the success colors from PrimeReact as it does have Success style.

@tandraschko
Copy link
Member

+1 to update the theme

propably we will support SUCCESS quite early for other components, when 5.0 is on the road

@melloware melloware assigned melloware and unassigned jepsar May 9, 2024
melloware added a commit to melloware/primefaces that referenced this issue May 9, 2024
@melloware
Fix primefaces#11375: StaticMessage add success severity
d397080
@melloware melloware mentioned this issue May 9, 2024
Merged
melloware added a commit to melloware/primefaces that referenced this issue May 9, 2024
@melloware
Fix primefaces#11375: StaticMessage add success severity
68aa102
melloware added a commit to melloware/primefaces that referenced this issue May 9, 2024
@melloware
Fix primefaces#11375: StaticMessage add success severity
3ac15a8
melloware added a commit to melloware/primefaces that referenced this issue May 9, 2024
@melloware
Fix primefaces#11375: StaticMessage add success severity
1a2f5cd
melloware added a commit that referenced this issue May 10, 2024
@melloware
Fix #11375: StaticMessage add success severity (#11901)
8d7ad0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
new feature
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

Fix #11375: StaticMessage add success severity melloware/primefaces
3 participants
@tandraschko @melloware @jepsar