Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7012: Slider add min max range functionality #7013

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Fix #7012: Slider add min max range functionality #7013

merged 3 commits into from
Feb 22, 2021

Conversation

buunsal
Copy link
Contributor

@buunsal buunsal commented Feb 19, 2021

image
I also commited new demos to showcase. Basic one not acceptable and contrary to what we use in our other ui libraries.
Primeng sample: Primeng Slider

But i need code review. It could be written better maybe.

@buunsal buunsal added the enhancement Additional functionality to current component label Feb 19, 2021
@buunsal buunsal added this to the 10.0.0-RC2 milestone Feb 19, 2021
@buunsal buunsal linked an issue Feb 19, 2021 that may be closed by this pull request
@melloware melloware changed the title Fix #7012: add min max range functionality Fix #7012: Slider add min max range functionality Feb 19, 2021
@tandraschko
Copy link
Member

tandraschko commented Feb 19, 2021

you also may adjust the taglib xml

@melloware
Copy link
Member

And \docs\migrationguide\10_0_0.md

@buunsal
Copy link
Contributor Author

buunsal commented Feb 19, 2021

added

@buunsal buunsal merged commit 972dc14 into primefaces:master Feb 22, 2021
@buunsal buunsal deleted the slider_range branch February 22, 2021 07:07
@melloware melloware modified the milestones: 10.0.0-RC2, 10.0.0 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality to current component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: min max range styles missing
3 participants