-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6409 - Datatable: ColumnGroup refactoring #9872
base: master
Are you sure you want to change the base?
Conversation
before you work on a PR which refactors such a important feature, we should discuss what you refactor and if we are all okay with it; especially PrimeTek and if we can also be backward compatible |
PrimeTek has already been pinged regarding this, and no answer. Community is aware of it, and also I'm trying to make it backward compatible as much as I can. If you have any feedbacks, please feel free to share in the original issue |
@Rapster I created #9572 and I wanted to delve into the So it would be cool if you maybe noticed how you can solve #9572 alongside with the code you refactored - maybe now it's much easier (for you) to solve #9572 with your refactored code. You already have a deep understanding of the Perhaps #9572 is now much easier to fix than with the current "old code" of the |
Don't wait for this PR to be merged, I don't think it's gonna happen anytime soon (few things must be done before having this merged) |
No stress. Maybe one day while editing this PR you will casually spot the cause of #9572. Maybe then the problem can be solved at the same time. Just a suggestion. I just wanted to draw your attention to #9572, since you are changing a lot in the |
@primefaces/primefaces-committers I'm actually thinking of not keeping the backward compatibility here, it's a lot of hassle to make it so for a feature which is not so much used... Hence the importance to make 15 final in 6 months |
@Rapster i agree that to fix this correctly it needs to be refactored as you have mentioned we just have to make the migration guide extremely detailed. I think more people use this feature than we think but who knows! 😄 |
No you're right, I had look on issues, and col group are used more than I thought... But it doesn't change my previous statement on how tricky it is to make things backward compatible. Hopefully, migration should be easy for people using nested grid with flexgrid (just to name one example) |
Fix #6409
Fix #9854