Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper CSS different from primeng project (v17.13.0) #121

Closed
meriturva opened this issue Apr 12, 2024 · 2 comments
Closed

Stepper CSS different from primeng project (v17.13.0) #121

meriturva opened this issue Apr 12, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@meriturva
Copy link

Just see:

https://github.com/primefaces/primeng/blob/a3b991d5f925706ef1e786b626ca01701beb91af/src/assets/components/themes/mira/theme.css#L4036

is completely different compared to the one on this repo:

So basically Stepper doesn't work correctly even with version 17.13.0.

I'm really confused but I guess that, to make this repo the 'only' one about theming aspects you have to use it on primeng components repo. Am I right?

why this repo is not used on primefaces/primeng/package.json ?

Thanks!

@meriturva meriturva changed the title Stepper CSS different from primeng project Stepper CSS different from primeng project (v17.13.0) Apr 12, 2024
@gregorwinkler
Copy link

I have the same issue and temporarily copied over lines 4036-4044 from https://github.com/primefaces/primeng/blob/a3b991d5f925706ef1e786b626ca01701beb91af/src/assets/components/themes/mira/theme.css into an own extension file on top of the base theme. By that it works, but should still be fixed properly in this repository.

@cetincakiroglu
Copy link
Contributor

Thanks a lot for reporting the issue, _stepper.scss import is missing in _component.scss. Fixing it now.

@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 19, 2024
@cetincakiroglu cetincakiroglu added the bug Something isn't working label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants