Skip to content

Commit

Permalink
Merge pull request #13619 from denny99/13596
Browse files Browse the repository at this point in the history
fix(Column-Filter): #13596 Auto close on Click Outside does not work
  • Loading branch information
cetincakiroglu committed Sep 25, 2023
2 parents 7ac7287 + 4698a19 commit b1e8def
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/app/components/table/table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4965,7 +4965,7 @@ export class ColumnFilter implements AfterContentInit {

private window: Window;

constructor(@Inject(DOCUMENT) private document: Document, public el: ElementRef, public dt: Table, public renderer: Renderer2, public config: PrimeNGConfig, public overlayService: OverlayService) {
constructor(@Inject(DOCUMENT) private document: Document, public el: ElementRef, public dt: Table, public renderer: Renderer2, public config: PrimeNGConfig, public overlayService: OverlayService, private cd: ChangeDetectorRef) {
this.window = this.document.defaultView as Window;
}

Expand Down Expand Up @@ -5337,6 +5337,7 @@ export class ColumnFilter implements AfterContentInit {

hide() {
this.overlayVisible = false;
this.cd.markForCheck();
}

onOverlayHide() {
Expand Down
2 changes: 1 addition & 1 deletion src/app/components/tieredmenu/tieredmenu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export class TieredMenuSub {

@ViewChild('sublist', { static: true }) sublistViewChild: ElementRef;

constructor(@Inject(DOCUMENT) private document: Document, public el: ElementRef, public renderer: Renderer2, private cd: ChangeDetectorRef, @Inject(forwardRef(() => TieredMenu)) public tieredMenu: TieredMenu) {}
constructor(public el: ElementRef, public renderer: Renderer2, private cd: ChangeDetectorRef, @Inject(forwardRef(() => TieredMenu)) public tieredMenu: TieredMenu) {}

positionSubmenu() {
let sublist = this.sublistViewChild && this.sublistViewChild.nativeElement;
Expand Down

1 comment on commit b1e8def

@vercel
Copy link

@vercel vercel bot commented on b1e8def Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.