Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Column-Filter): #13596 Auto close on Click Outside does not work #13619

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

denny99
Copy link
Contributor

@denny99 denny99 commented Sep 6, 2023

Fixes #13596

Notes for the other misc. Changes:

For some reason the other 3 files failed during the prettier check
image
So i just re ran the prettier command to format them.
As i reviewed those files i saw, that the document injection in the tiered menu was unused and cleaned up the code

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 1:35pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 1:35pm

@denny99
Copy link
Contributor Author

denny99 commented Sep 6, 2023

Side Note: Some files i did not touch had a corrupted formatting and i had to re run prettier

@denny99
Copy link
Contributor Author

denny99 commented Sep 20, 2023

Solved Merge Conflict

@cetincakiroglu cetincakiroglu merged commit b1e8def into primefaces:master Sep 25, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column Filter: Auto close on Click Outside does not work
4 participants