Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay: p-overlay div not removed from DOM on hiding panel #12948

Closed
RinoGaetano94 opened this issue Apr 26, 2023 · 1 comment · Fixed by #13659
Closed

Overlay: p-overlay div not removed from DOM on hiding panel #12948

RinoGaetano94 opened this issue Apr 26, 2023 · 1 comment · Fixed by #13659
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@RinoGaetano94
Copy link

RinoGaetano94 commented Apr 26, 2023

Describe the bug

When hiding the overlay content (clicking outside the panel or programmatically) the wrapper div with class 'p-overlay' will not be removed from the DOM. This will cause an invisible layer blocking interactions with the page. If you perform another click, the p-overlay div will be removed from DOM.

It seems to happen only if responsive params is passed.

It seems to work properly on 14.2.2 Official Documentation.

This is the div that should be removed from DOM (it will removed on second click)
Schermata del 2023-04-26 10-43-23

Environment

PrimeNG Official Documentation

Reproducer

https://primeng.org/overlay#basic

Angular version

15.2.2

PrimeNG version

15.1.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Trigger the responsive breakpoint resizing the window.
  2. Click the "Show Overlay" button in the basic example.
  3. Click outside the overlay panel to make it disappear.

If you try to click the "Show Overlay" button again to reopen the overlay, it will fail. You will not see the cursor pointer too.

Even if the click fails, the p-overlay wrapper will be correctly removed this time

Expected behavior

When hiding overlay panel, the p-overlay wrapper should be removed from DOM to re-establish the page interaction

@RinoGaetano94 RinoGaetano94 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 26, 2023
@faisal6699
Copy link
Contributor

faisal6699 commented Sep 12, 2023

It still exists. Need immediate solve :|

ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 12, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 25, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
ashikjs added a commit to ashikjs/primeng that referenced this issue Sep 27, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 8, 2023
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 8, 2023
cetincakiroglu added a commit that referenced this issue Nov 8, 2023
…-mobile-view-issue

fix: #12948 || Overlay: p-overlay div not removed from DOM on hiding …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants