fix: #12948 || Overlay: p-overlay div not removed from DOM on hiding …

[ashikjs]

Fix: #12948

Previously I did try to solve it by z-index for CSS animation but now I re-check hole process and identified that dome should remove when overlay is hide.

There issue was after complete animation this.modalVisible = false; can not event fire angular change detection life cycle so dome was not removed properly so we fire it manually by this.cd.markForCheck() then dome gone and solve it issues.

Extra code:

I removed event from (click)="onOverlayClick($event)" because onOverlayClick function don't have any parameter.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
primeng-ssr-test	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2023 0:14am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Sep 27, 2023 0:14am

[ashikjs]

@mertsincan and @gucal hi, can you please check this PR. Thanks in advance.

[SoyDiego]

I don't know if this is related with a previous PR that I did. Please check if it's possible #13501

Thanks

[ashikjs]

@SoyDiego Thanks for your concern. I checked PR and Issues you mentions. those are not relevent to this PR.

Actually here I am ensuring that default overlay z-index is negative so it shouldn't do any side effect to others.
Previously overlap was not any z-index.

[SoyDiego]

@SoyDiego Thanks for your concern. I checked PR and Issues you mentions. those are not relevent to this PR.

Actually here I am ensuring that default overlay z-index is negative so it shouldn't do any side effect to others. Previously overlap was not any z-index.

Thanks for double check 👌

[cetincakiroglu]

Hi @ashikjs,

We cannot set z-index manually in this case we've got a utility function called zIndexUtils in components/utils, could you please remove the manual CSS and use zIndexUtils? You can check the sidebar or dialog to see how we manage zIndex by using zIndexUtils.

[ashikjs]

@cetincakiroglu ok let me try.

[ashikjs]

@cetincakiroglu can you check my PR now. I wrote details about my latest change in description box.

[ashikjs]

@gucal and @cetincakiroglu can you check my PR.