Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar: Inconsistent naming and wrong documentation #13814

Closed
anlampe opened this issue Oct 5, 2023 · 0 comments · Fixed by #13815
Closed

Toolbar: Inconsistent naming and wrong documentation #13814

anlampe opened this issue Oct 5, 2023 · 0 comments · Fixed by #13815
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.4

Comments

@anlampe
Copy link
Contributor

anlampe commented Oct 5, 2023

Describe the bug

There is generally an inconsistency regarding the naming of the templates (left vs. start, right vs. end). Additionally the documentation doesn't reflect the implementation of the Toolbar.

The documentation states:

Toolbar provides start, center and end templates to place content at these sections.

The Toolbar component instead expects the component names left, center and right.

Environment

Reproducer

https://stackblitz.com/edit/4ijavk?file=src%2Fapp%2Fdemo%2Ftoolbar-basic-demo.html

Angular version

16.2.0

PrimeNG version

16.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.17.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@anlampe anlampe added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 5, 2023
anlampe added a commit to anlampe/primeng that referenced this issue Oct 5, 2023
@anlampe
Toolbar: Accept documented template names primefaces#13814
b972b93
@anlampe anlampe mentioned this issue Oct 5, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 11, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.2 milestone Oct 11, 2023
cetincakiroglu added a commit that referenced this issue Oct 11, 2023
@cetincakiroglu
Merge pull request #13815 from anlampe/toolbar-accept-documented-temp…
32ee09b 
…late-names

Toolbar: Accept documented template names #13814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.4
Development

Successfully merging a pull request may close this issue.

Toolbar: Accept documented template names #13814 anlampe/primeng
2 participants
@cetincakiroglu @anlampe