Toolbar: Accept documented template names #13814 #13815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
SoyDiego
reviewed
Oct 7, 2023
| @@ -19,6 +20,11 @@ export class ToolbarDemo { | |||
| label: 'Basic', | |||
| component: BasicDoc | |||
| }, | |||
| { | |||
| id: 'template', | |||
| label: 'Template', | |||
There was a problem hiding this comment.
Maybe you can add a description for template section like the others sections.
There was a problem hiding this comment.
I have added a description, I hope it is ok now. Thanks for reviewing!
cetincakiroglu
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13814
There is generally an inconsistency regarding the naming of the templates (left vs. start, right vs. end). Additionally the documentation doesn't reflect the implementation of the Toolbar, means it only accepts right and left as template names.
Fix
The Toolbar now additionally accepts the template names
startandend.