Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: Accessibility role not available #13843

Closed
ethanolree opened this issue Oct 9, 2023 · 1 comment · Fixed by #13849
Closed

Tooltip: Accessibility role not available #13843

ethanolree opened this issue Oct 9, 2023 · 1 comment · Fixed by #13849
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.4.4

Comments

@ethanolree
Copy link

Describe the bug

Duplicate of closed issue #13044

Accessibility documentation for the Tooltip claims the tooltip role will be added to the component and an associated id can be used with aria-describedby. However, neither the role nor the id exist on the generated tooltip.

image

Environment

PrimeNG version 16.3.1

Reproducer

No response

Angular version

16.2.5

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

Use of tooltip component

Expected behavior

Rendered tooltip component should display both role and id
@ethanolree ethanolree added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 9, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.2 milestone Oct 10, 2023
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 10, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks for reporting the missing attributes. They'll be added in the upcoming release.

mehmetcetin01140 added a commit to mehmetcetin01140/primeng that referenced this issue Oct 10, 2023
@mehmetcetin01140
Fixed primefaces#13843 - Add id and role attributes to tooltip for ac…
6c53f9d 
…cessibility
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Oct 10, 2023
Merged
cetincakiroglu added a commit that referenced this issue Oct 11, 2023
@cetincakiroglu
Merge pull request #13849 from mehmetcetin01140/#13843
b66e4f6 
Fixed #13843 - Add id and role attributes to tooltip for accessibility
mehmetcetin01140 added a commit to mehmetcetin01140/primeng that referenced this issue Oct 13, 2023
@mehmetcetin01140
Fixed primefaces#13866 - Revert regression of content template and re…
604fc99 
…factor primefaces#13843
cetincakiroglu added a commit that referenced this issue Oct 13, 2023
@cetincakiroglu
Merge pull request #13881 from mehmetcetin01140/master
af9061f 
Fixed #13866 - Revert regression of content template and refactor #13843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.4.4
Development

Successfully merging a pull request may close this issue.

Fixed #13843 - Add id and role attributes to tooltip for accessibility mehmetcetin01140/primeng
2 participants
@cetincakiroglu @ethanolree