Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip doesn't accept TemplateRef<HTMLElement> anymore #13866

Closed
Marc-AntoineGL opened this issue Oct 12, 2023 · 3 comments · Fixed by #13881
Closed

Tooltip doesn't accept TemplateRef<HTMLElement> anymore #13866

Marc-AntoineGL opened this issue Oct 12, 2023 · 3 comments · Fixed by #13881
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Marc-AntoineGL
Copy link

Describe the bug

Hello, sorry in advance if my issue is not clear enough, that's my first one.

I am using tooltip and displaying a template inside it with a TemplateRef.

But a recent commit has removed that possibility, this following code has been changed:

@Input('pTooltip') content: string | TemplateRef<HTMLElement> | undefined;

I don't know if it was on purpose or not, but according to this, your documentation about tooltip is now outdated mentionning "Tooltip can use either a string or a TemplateRef."

On top of that I have been impacted by a change in the constructor taking as argument a ChangeDetectorRef instead of a ViewContainerRef previously.

constructor(@Inject(PLATFORM_ID) private platformId: any, public el: ElementRef, public zone: NgZone, public config: PrimeNGConfig, private renderer: Renderer2, private viewContainer: ViewContainerRef) {}

Since these two changes are not really linked with the commit message "Add id and role attributes to tooltip for accessibility" I would like to know if they are going to be kept or not so I can update my code accordingly if yes.

For the moment I'm keeping my 16.4.1, so let me know.

Regards.

Environment

Angular app

Reproducer

No response

Angular version

^16.2.2

PrimeNG version

16.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@Marc-AntoineGL Marc-AntoineGL added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 12, 2023
@lwestfall
Copy link
Contributor

Wow, this is serendipitous. I just ran into this and was going to submit an issue myself.

@jncalderon
Copy link

jncalderon commented Oct 12, 2023

I have this issue as well :(

image

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 13, 2023
@cetincakiroglu cetincakiroglu added this to the 16.5.1 milestone Oct 13, 2023
mehmetcetin01140 added a commit to mehmetcetin01140/primeng that referenced this issue Oct 13, 2023
cetincakiroglu added a commit that referenced this issue Oct 13, 2023
Fixed #13866 - Revert regression of content template and refactor #13843
@bemes9226
Copy link

so we need to add this code in my ts file, need some assist here in satckblitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants