Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button with Icon: the label is not updated when used with a pipe #1719

Closed
iguissouma opened this issue Jan 3, 2017 · 1 comment
Closed

Button with Icon: the label is not updated when used with a pipe #1719

iguissouma opened this issue Jan 3, 2017 · 1 comment
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
2.0-RC1

Comments

@iguissouma
Copy link

When used with a pipe such as translate (ng2-translate) the label is not correctly updated.
First display - OK
2017-01-03_10h57_00
After language switch - KO
2017-01-03_11h00_18

DOM

2017-01-03_11h07_14

"primeng": "^1.1.1",
"@angular/core": "2.2.1",
"ng2-translate": "^4.0.0",

I'm using the ultima-ng theme but I don't thik the problem is related to the theme.
@iguissouma iguissouma changed the title Button label is not updated when used with a pipe Button With Icon: the label is not updated when used with a pipe Jan 4, 2017
@iguissouma iguissouma changed the title Button With Icon: the label is not updated when used with a pipe Button with Icon: the label is not updated when used with a pipe Jan 4, 2017
@donriver
Copy link

I have the similar issue, and it seems that it's related to #1685

kryzys69 pushed a commit to kryzys69/primeng that referenced this issue Jan 15, 2017
Update button.ts
3a34aef 
This simple change closes primefaces#1685 and primefaces#1719. I don't know what was the point of this change, but it was okay before commit b976a9d.
@kryzys69 kryzys69 mentioned this issue Jan 15, 2017
Merged
@cagataycivici cagataycivici self-assigned this Jan 18, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 18, 2017
@cagataycivici cagataycivici added this to the 2.0 milestone Jan 18, 2017
cagataycivici added a commit that referenced this issue Jan 18, 2017
@cagataycivici
Merge pull request #1815 from kryzys69/patch-1
110f995 
Fixed #1685 and #1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
2.0-RC1
Development

No branches or pull requests
3 participants
@cagataycivici @iguissouma @donriver