Button with Icon: the label is not updated when used with a pipe #1719

Closed
iguissouma opened this Issue Jan 3, 2017 · 1 comment

Projects

None yet

3 participants

@iguissouma

When used with a pipe such as translate (ng2-translate) the label is not correctly updated.
First display - OK
2017-01-03_10h57_00
After language switch - KO
2017-01-03_11h00_18

DOM

2017-01-03_11h07_14

"primeng": "^1.1.1",
"@angular/core": "2.2.1",
"ng2-translate": "^4.0.0",

I'm using the ultima-ng theme but I don't thik the problem is related to the theme.

@iguissouma iguissouma changed the title from Button label is not updated when used with a pipe to Button With Icon: the label is not updated when used with a pipe Jan 4, 2017
@iguissouma iguissouma changed the title from Button With Icon: the label is not updated when used with a pipe to Button with Icon: the label is not updated when used with a pipe Jan 4, 2017
@donriver

I have the similar issue, and it seems that it's related to #1685

@kryzys69 kryzys69 pushed a commit to kryzys69/primeng that referenced this issue Jan 15, 2017
kryzys69 Update button.ts
This simple change closes #1685 and #1719. I don't know what was the point of this change, but it was okay before commit b976a9d.
3a34aef
@cagataycivici cagataycivici self-assigned this Jan 18, 2017
@cagataycivici cagataycivici added this to the 2.0 milestone Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment