Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a template for DynamicDialog footer #7603

Closed
NathanAlcantara opened this issue Apr 25, 2019 · 13 comments
Closed

Create a template for DynamicDialog footer #7603

NathanAlcantara opened this issue Apr 25, 2019 · 13 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add

Comments

@NathanAlcantara
Copy link

NathanAlcantara commented Apr 25, 2019

** I'm submitting to ... **
[] bug report
[X] feature request
[] support request

** Current behavior **
Today it's only possible to put a string in footer

** Expected behavior **
It would be interesting put a template, where you can put anything there
Like the p-dialog where you can put a p-footer

** What is the motivation / use case for changing the behavior? **
I need to show a button on a p-dynamicdialog footer.

** Please tell us about your environment: **
I'm using Win10 and Yarn for my package manager

  • ** Angular version: ** 7.2.6

  • ** PrimeNG version: ** 7.0.0

  • ** Browser: ** all

  • ** Language: ** all

  • ** Node (for AoT issues): ** node --version = 10.13.0

@BensonBen
Copy link

I would also like this feature, but update your issue to correctly reflect the class you're trying to reference

@NathanAlcantara NathanAlcantara changed the title Create a template for DymicDialog footer Create a template for DynamicDialog footer Apr 26, 2019
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 21, 2020
@praneeshc
Copy link

Is this available?

@BensonBen
Copy link

I've solved this issue on my own to see if it was possible, as well as, several other features that would be useful. Looks like there's an interest in it. I'll try and get a pull request out this weekend

@praneeshc
Copy link

@BensonBen, That would be really helpful. Please comment when you have this completed. Thanks

@Menyueru
Copy link

I needed this too but for the header, I patched it in on my end by changing the header to instead be a innerhtml binding and it seems to be working fine, still trying to find a more elegant solution though.

@17797776321
Copy link

If you want to implement dynamic diaolog, you can do the following:
1、Write

at the bottom of your component;

image

2、Configure the contentstyle parameter in your dialogservice.open method. Just like contentStyle:{
"padding-bottom":"50px"
}
image

@lucassalatiel1993
Copy link

Can anyone tell me if this improvement will be implemented?

@MrTob
Copy link

MrTob commented Sep 12, 2022

same here, need it very quickly

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@saramcicchi
Copy link

Hi @mertsincan - this feature has not been added. Can you please reopen the issue?

@mertsincan mertsincan reopened this Nov 11, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 11, 2022
@yBouzeliffa
Copy link

i just needed the feature, thank u @toxaq, hope it's will be deploy soon

@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Dec 28, 2023

Hi,

You can use templating options of dynamic dialog https://primeng.org/dynamicdialog#api.dynamicdialog-ref.interfaces.DynamicDialogTemplates

Please also see the example: https://primeng.org/dynamicdialog#example

@RafalSzczuka
Copy link

Hi,

You can use templating options of dynamic dialog https://primeng.org/dynamicdialog#api.dynamicdialog-ref.interfaces.DynamicDialogTemplates

Please also see the example: https://primeng.org/dynamicdialog#example

@cetincakiroglu Is there any chance to support adding header/content/footer by referencing some specific directive (simply pass TemplateRef). The possibility to pass only the Footer or Header components is quite inconvenient. It would be nice to have an option, building dialog contents, to just put a directive over a element, and that directive would be checked in Prime Dialog component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests