Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to template dynamic dialogs. #12068

Closed
wants to merge 1 commit into from
Closed

Add ability to template dynamic dialogs. #12068

wants to merge 1 commit into from

Conversation

toxaq
Copy link

@toxaq toxaq commented Oct 20, 2022

###Defect Fixes
Solves #9235 and #7603

Backward compatible, simply set config.minimal to true and you can use dialog templates as follows:

<p-dialog-title>
  <h3>Example title</h3>
</p-dialog-title>
<p-dialog-content><p>example content here</p></p-dialog-content>
<p-dialog-actions>
  <button (click)="cancel()">Cancel</button>
  <button (click)="delete()">Delete</button>
</p-dialog-actions>

@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 21, 2022
@cetincakiroglu cetincakiroglu added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Nov 15, 2022
@Stankman
Copy link

Has this been added?

@cetincakiroglu cetincakiroglu added this to the 15.Future milestone Jan 26, 2023
@gboutte
Copy link

gboutte commented Mar 9, 2023

Hi, is there any informations about when it will be published ?

@m4n50n
Copy link

m4n50n commented Apr 14, 2023

I need this

@dougmbarcellos
Copy link

Any predictions for releasing the feature?

@toxaq toxaq closed this Jun 19, 2023
@dougmbarcellos
Copy link

Please reopen this pull request.

The feature has not yet been implemented.

@MetroMarv
Copy link

The PR has been closed without a comment? Does the PR not meet your requirements or are you working on a different solution to the problem?

@toxaq
Copy link
Author

toxaq commented Jul 26, 2023

@MetroMarv I closed it because after receiving zero feedback on my submission, and realising that the original issues are from 2019 and 2020 respectively, it was clear this is going nowhere. I've decided to change the UI library I've adopted and so won't be rebasing this against an ever moving codebase.

@MetroMarv
Copy link

Sorry @toxaq I didn't realize it was you as the PR creator who closed the PR.

@dougmbarcellos
Copy link

Feature added in version 17: #14354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants