Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-tabPanel does not detect changes when "disabled" binding is changed #9475

Closed
kali-dali opened this issue Oct 30, 2020 · 7 comments
Closed
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team

Comments

@kali-dali
Copy link

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Demo on Stackblitz
https://stackblitz.com/edit/primeng-tabview-disbale-bug?file=src/app/app.component.html

Current behavior
When I change the [disabled] binding of a p-tabPanel component, the change is only detected when I click on the changed tab.

Expected behavior
When I change the [disabled] binding of a p-tabPanel component, I expect the component to change to disabled/enabled state immediately.

Please tell us about your environment:
OS: Windows 10
Browser: Chrome
Angular Version: 10.2.0
PrimeNG: Version 10.0.3

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 25, 2020
@StevenFischerWI
Copy link

I'm having the same non-change-detection issue with basic properties like [header] and [leftIcon].

https://primeng-tabview-disbale-bug-qjzcja.stackblitz.io

Windows 10/Chrome/Angular 11.02, PrimeNG Version 11.0.0-rc.1

@MightyMorpheus
Copy link

Same issue here. headerStyleClass is not updating neither.

I'd like to highlight tab with form validation errors, but it does not update: [headerStyleClass]="submitAttempted && form.get('basicInfo').invalid ? 'ng-dirty ng-invalid' : ''"

I tried to use getter and put there console.log. The getter is called as usual and returns css classes as expected, but component does not update the header style.

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@gstokesRev
Copy link

Hi Folks

Could this issue be reopened please, we have the very same problem as described and have updated to the latest version of PrimeNG and its doesn't solve the problem. This is quite a major blocker for us

Thanks

@mertsincan mertsincan reopened this Nov 16, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 16, 2022
Feher-Zsofia added a commit to Feher-Zsofia/primeng that referenced this issue Sep 7, 2023
primefaces#9475
getter/setter for header style changes
should look into the rest of the properties
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 22, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Couldn't replicate the issue with the latest PrimeNG. Here is the stackblitz example of the same code with the primeng v16.3.1: https://stackblitz.com/edit/mfhtwi?file=src%2Fapp%2Fdemo%2Ftab-view-disabled-demo.html,src%2Fapp%2Fdemo%2Ftab-view-disabled-demo.ts

TabPanel works as expected, closing the issue.

@cetincakiroglu cetincakiroglu added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Sep 22, 2023
@github-actions
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@Feher-Zsofia
Copy link
Contributor

Hi,

Please look up the follow-up bugs on this very same issue: #9475 (comment)

It is still an issue, and it is a very important one for big forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants