Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #9475 : p-tabPanel does not detect style changes #13624

Closed
wants to merge 1 commit into from

Conversation

Feher-Zsofia
Copy link
Contributor

@Feher-Zsofia Feher-Zsofia commented Sep 7, 2023

Fix #9475

Fix for #9475 "latter half", where dynamic changes on tabpanel style are not detected.

primefaces#9475
getter/setter for header style changes
should look into the rest of the properties
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 10:30am

@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 7, 2023

Add in your first comment the text Fix #9475 and will link your PR with the issue and if PrimeNG Team approve it, will close automatically the issue.

@cetincakiroglu
Copy link
Contributor

Hi,

Couldn't replicate the issue with the latest PrimeNG. Here is the StackBlitz example of the same code with the primeng v16.3.1: https://stackblitz.com/edit/mfhtwi?file=src%2Fapp%2Fdemo%2Ftab-view-disabled-demo.html,src%2Fapp%2Fdemo%2Ftab-view-disabled-demo.ts

TabPanel works as expected, closing the PR.

Thanks for your effort and support!

@Feher-Zsofia
Copy link
Contributor Author

Hi,
Disabled changes were working, style changes were NOT however. In a massive, multi tabbed form dynamic style changes are a MUST. Please review this again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-tabPanel does not detect changes when "disabled" binding is changed
3 participants