Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12349 pfocustrap hidden ancestor fix #12453

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

mmorgan4x
Copy link
Contributor

@mmorgan4x mmorgan4x commented Jan 3, 2023

Fixed #12349

@mmorgan4x mmorgan4x changed the title fixed tests by appending element to body #12349 fixed tests by appending element to body Jan 3, 2023
@mmorgan4x mmorgan4x changed the title #12349 fixed tests by appending element to body #12349 focustrap hidden ancestor fix Jan 3, 2023
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Jan 4, 2023

Hi @mmorgan4x,

I see that there is still a test error exists in domhandler.spec.ts, could you please run "npm run test:headless" and refactor the domhandler.spec.ts file?

@mmorgan4x
Copy link
Contributor Author

@cetincakiroglu I have updated the tests. Is there a reason the checks keep failing for the pr-open-check?

@mmorgan4x mmorgan4x changed the title #12349 focustrap hidden ancestor fix #12349 pfocustrap hidden ancestor fix Jan 12, 2023
@cetincakiroglu cetincakiroglu merged commit 8c019aa into primefaces:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pFocusTrap: focus stuck when ancestor of tabbable element is hidden
2 participants