Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements and refactor for Angular Universal Support #12820

Merged
merged 60 commits into from
Mar 29, 2023
Merged

Enhancements and refactor for Angular Universal Support #12820

merged 60 commits into from
Mar 29, 2023

Conversation

cetincakiroglu
Copy link
Contributor

@cetincakiroglu cetincakiroglu commented Mar 26, 2023 •
edited
Loading

Fixes #12810

@cetincakiroglu
Add method to check client
c72ac8f
@cetincakiroglu
Add document injection and renderer
0d38f9e
@cetincakiroglu
Inject document and use renderer
4946f33
@cetincakiroglu
Inject document
7f73a3d
@cetincakiroglu
Refactor for ssr
ec1ed11
@cetincakiroglu
Inject document
22a6373
@cetincakiroglu
Inject document
7fee62e
@cetincakiroglu
Inject document and refactor for ssr
c9f0964
@cetincakiroglu
Inject document and refactor for ssr
045dbdd
@cetincakiroglu
Inject document and refactor for ssr
e29ccbb
@cetincakiroglu
Inject document and refactor for ssr
aba3f8b
@cetincakiroglu
Inject document and refactor for ssr
134d937
@cetincakiroglu
Inject document and refactor for ssr
e4f25ed
@cetincakiroglu
Inject document and refactor for ssr
30cee58
@cetincakiroglu
Inject document and refactor for ssr
97e62fd
@cetincakiroglu
Inject document and refactor for ssr
07ced71
@cetincakiroglu
Inject document and refactor for ssr
2dbc785
@cetincakiroglu
Inject document and refactor for ssr
5cc2ba2
@cetincakiroglu
Inject document and refactor for ssr
45ea5b6
@cetincakiroglu
Inject document and refactor for ssr
e86d02b
@cetincakiroglu
Inject document and refactor for ssr
6f98610
@cetincakiroglu
Refactor
a43dc2f
@cetincakiroglu
Inject document and refactor for ssr
a1839c7
@cetincakiroglu
Inject document and refactor for ssr
f2c387f
@cetincakiroglu
Refactor
2ace184
@cetincakiroglu
Inject document and refactor for ssr
b8dee49
@cetincakiroglu
Inject document and refactor for ssr
ee67d93
@cetincakiroglu
Inject document and refactor for ssr
7f91361
@cetincakiroglu
refactor
d5d74a9
@cetincakiroglu
Inject document and refactor for ssr
bb13954
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

4 similar comments
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@cetincakiroglu cetincakiroglu linked an issue Mar 29, 2023 that may be closed by this pull request
Angular Universal Support #12810
Closed
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

1 similar comment
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions
Copy link

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'npm run test:headless' and commit the changes.

@github-actions
Copy link

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'npm run test:headless' and commit the changes.

@github-actions github-actions bot removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 29, 2023
@cetincakiroglu cetincakiroglu merged commit 8b05d64 into master Mar 29, 2023
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 29, 2023
@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to fit our code format standards. Please run the 'npm run format' command and commit the changes.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Mar 29, 2023
@cetincakiroglu cetincakiroglu deleted the ssr branch April 3, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyjus25 kyjus25 kyjus25 requested changes

Assignees
No one assigned
Labels
Angular Universal Issue or pull request is related to Angular Universal Server Side Rendering Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular Universal Support
3 participants
@cetincakiroglu @volvachev @kyjus25