Fix for incorrect behaviour when a column is both sortable and filter… #13392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gucal
added
the
Status: Pending Review
|
Thanks a lot for your contribution! |
gucal
removed
the
Status: Pending Review
rosenthalj
added a commit
to rosenthalj/primeng
that referenced
this pull request
Sep 26, 2023
merge pull request primefaces#13392 fixed issue primefaces#13361 but caused filters not to automatically close when clicking different filter buttons. This change properly fixes issue primefaces#13361 and as a result fixes the bug that was induced by the original attempted fix. Instead of stopping the click event propagation, the isFilterElement method is improved by calling a new isFilterElementIconOrButton method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fix #13361
The event is being propagated from filter button click handler to parent div (whose click handler performs sorting)
Solution
Stop the event from propagation in the filter button click handler.
As we are preventing the event propagation, we dont have to check for 'isFilterElement'
@cetincakiroglu