properly fix issue #13361 #13754
Merged
properly fix issue #13361 #13754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge pull request primefaces#13392 fixed issue primefaces#13361 but caused filters not to automatically close when clicking different filter buttons. This change properly fixes issue primefaces#13361 and as a result fixes the bug that was induced by the original attempted fix. Instead of stopping the click event propagation, the isFilterElement method is improved by calling a new isFilterElementIconOrButton method
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13392
Merge pull request #13392 fixed issue #13361 but caused filters not to automatically close when clicking different filter icon buttons.
This pull request fixes "properly" issue #13361 and as a result fixes the bug that was induced by the original attempted fix.
This pull request reverts the original changes to fix issue #13361. Instead of stopping the click event propagation, the original isFilterElement method is reinstated and is improved by calling a new isFilterElementIconOrButton method.
The following demonstrates step by step the original issue, the incorrect fix, and the improved fix.
Movie 1) shows the original issue #13361 in v16.0.2
1_bad_16.0.2_IncorrectSortAndFilter.mov
Movie 2) shows proper filter clicking behavior in v16.0.2 before merge request #13392 breaks the funcitonality
2_good_16.0.2_clickOnFilter.mov
Movie 3) shows that issue #13361 in v16.3.1 is fixed by merge request #13392
3_good_16.3.1_fix13392_IncorrectSortAndFilter.mov
Movie 4) shows that v16.3.1 merge request #13392 breaks filter click icon functionality
4_bad_16.3.1_fix13392_clickOnFilter.mov
Movie 5) shows that the changes in this pull request also fixes the issue #13361
5_good_newFix_IncorrectSortAndFilter.mov
Movie 6) shows that the changes in this pull request also fixes the filter click icon functionality that was broken by merge request #13392
6_good_newFix_clickOnFilter.mov