Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-Dropdown within accordion loses focus #15418

Conversation

nbrown-ScottLogic
Copy link
Contributor

@nbrown-ScottLogic nbrown-ScottLogic commented May 1, 2024

FIXED #14953

FIXED #15406

As the accordion keypress functions never checked that the accordion was highlighted if a component within it was active and had a keypress it would still execute its own keypress functionality thereby changing the focus to the next tab.

nbrown-ScottLogic and others added 2 commits May 1, 2024 15:20
…ctually the active element. The functions for keypresses were running and thereby changing the selected component
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 3:48pm

@cetincakiroglu
Copy link
Contributor

Hi,

We don't need to modify accordion, correct fix is to add missing stopPropagation to arrow handler functions. This issue is fixed in #15446

Closing the PR, thanks a lot for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants