Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: blockScroll not working #3166

Closed
wshuman3 opened this issue Aug 18, 2022 · 1 comment · Fixed by #3167 or #3187
Closed

Dialog: blockScroll not working #3166

wshuman3 opened this issue Aug 18, 2022 · 1 comment · Fixed by #3167 or #3187
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.5.0

Comments

@wshuman3
Copy link

Describe the bug

blockScroll adds the class p-overflow-hidden to the body when it is shown but it is not removed when it is closed

Reproducer

https://codesandbox.io/s/primereact-test-forked-2vbvp2

PrimeReact version

8.3.0

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

ALL

Steps to reproduce the behavior

1.) Click Show Dialog
2.) Click Close in Dialog
3.) Notice "p-overflow-hidden" is still present on the body

Expected behavior

p-overflow-hidden is removed when the dialog is closed
@wshuman3 wshuman3 added Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Bug Issue contains a defect related to a specific component. labels Aug 18, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2022
@melloware
Fix primefaces#3166: Dialog remove body hidden on blockScroll close
3e083e9
@melloware melloware mentioned this issue Aug 18, 2022
Merged
@melloware melloware added 👍 confirmed and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 18, 2022
@melloware melloware self-assigned this Aug 18, 2022
@melloware melloware added this to the 9.0.0 milestone Aug 18, 2022
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2022
@melloware
Fix primefaces#3166: Dialog remove body hidden on blockScroll close
c82e8b3
melloware added a commit that referenced this issue Aug 18, 2022
@melloware
Fix #3166: Dialog remove body hidden on blockScroll close (#3167)
ae93645
@mertsincan mertsincan modified the milestones: 9.0.0, 8.4.0 Aug 22, 2022
@melloware melloware reopened this Aug 23, 2022
@melloware melloware modified the milestones: 8.4.0, 8.5.0 Aug 23, 2022
@melloware
Copy link
Member

I am still seeing this issue in 8.4.0 so re-opening.

melloware added a commit to melloware/primereact that referenced this issue Aug 25, 2022
@melloware
Fix primefaces#3166: Dialog remove blockScroll on exit
da24807
@melloware melloware mentioned this issue Aug 25, 2022
Merged
melloware added a commit to melloware/primereact that referenced this issue Aug 25, 2022
@melloware
Fix primefaces#3166: Dialog remove blockScroll on exit
f431979
melloware added a commit that referenced this issue Aug 25, 2022
@melloware
Fix #3166: Dialog remove blockScroll on exit (#3187)
2124ad5
@melloware melloware mentioned this issue Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.5.0
3 participants
@wshuman3 @melloware @mertsincan