Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitter: widths provided to SplitterPanel.size are not correctly applied #3534

Closed
kalinkrustev opened this issue Oct 31, 2022 · 0 comments · Fixed by #3535
Closed

Splitter: widths provided to SplitterPanel.size are not correctly applied #3534

kalinkrustev opened this issue Oct 31, 2022 · 0 comments · Fixed by #3535
Assignees
@kalinkrustev
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.1

Comments

@kalinkrustev
Copy link
Contributor

Describe the bug

Widths supplied to the size property are divided by the number of SplitterPanels.

Reproducer

https://codesandbox.io/s/primereact-test-forked-lyx7jp?file=/src/index.js

PrimeReact version

8.7.0

React version

17.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Open the reproducer URL and inspect the spitpanel widths, where they will wrongly be set to
flex-basis: calc(5% - 4px);
flex-basis: calc(45% - 4px);
insted of
flex-basis: calc(10% - 4px);
flex-basis: calc(90% - 4px);

Expected behavior

Correctly apply the provided widths.
@kalinkrustev kalinkrustev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 31, 2022
kalinkrustev added a commit to kalinkrustev/primereact that referenced this issue Oct 31, 2022
@kalinkrustev
Fix: primefaces#3534
2b942fa
@kalinkrustev kalinkrustev mentioned this issue Oct 31, 2022
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 31, 2022
@melloware melloware added this to the 8.7.1 milestone Oct 31, 2022
melloware pushed a commit that referenced this issue Oct 31, 2022
@kalinkrustev
Fix #3534: Splitter: widths provided to SplitterPanel.size are not co…
0792351 
…rrectly applied (#3535)

* Fix: #3534

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalinkrustev kalinkrustev

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.1
2 participants
@kalinkrustev @melloware