-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3534: Splitter: widths provided to SplitterPanel.size are not correctly applied #3535
Conversation
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Looks like you need to run prettier format |
Yes and I think the issue was caused when I was trying to satisfy the linter. I think I got a similar error in my previous PR. |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
I admit I do not have memorized the full 18 levels of JS operator precedence and when Prettier insists to remove the extra brackets, it might look "prettier", but then requires the reader (which includes me) of the source code to also memorize these 18 levels. |
You can also add |
OK, I will know for the next time. But then it looks suspicious :) |
HA true! |
Fix: #3534