Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3534: Splitter: widths provided to SplitterPanel.size are not correctly applied #3535

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

kalinkrustev
Copy link
Contributor

Fix: #3534

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@melloware
Copy link
Member

Looks like you need to run prettier format

@kalinkrustev
Copy link
Contributor Author

Yes and I think the issue was caused when I was trying to satisfy the linter. I think I got a similar error in my previous PR.

@github-actions
Copy link

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@kalinkrustev
Copy link
Contributor Author

I admit I do not have memorized the full 18 levels of JS operator precedence and when Prettier insists to remove the extra brackets, it might look "prettier", but then requires the reader (which includes me) of the source code to also memorize these 18 levels.

@melloware
Copy link
Member

You can also add // prettier-ignore if you don't want it touched.

@kalinkrustev
Copy link
Contributor Author

OK, I will know for the next time. But then it looks suspicious :)

@melloware
Copy link
Member

HA true!

@melloware melloware merged commit 0792351 into primefaces:master Oct 31, 2022
kalinkrustev added a commit to kalinkrustev/primereact that referenced this pull request Nov 15, 2022
melloware pushed a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitter: widths provided to SplitterPanel.size are not correctly applied
2 participants