Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: PrimeReact.nullSortOrder not working correctly #3712

Closed
melloware opened this issue Nov 28, 2022 · 0 comments · Fixed by #3713
Closed

Core: PrimeReact.nullSortOrder not working correctly #3712

melloware opened this issue Nov 28, 2022 · 0 comments · Fixed by #3713
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.3

Comments

@melloware
Copy link
Member

melloware commented Nov 28, 2022 •
edited
Loading

Describe the bug

original fix did not fix it: #3114

PrimeReact.nullSortOrder = 1; sort like excel with all nulls at the bottom

PrimeReact.nullSortOrder = -1; sort NULLs at top on ASC and bottom on DESC

Reproducer

https://codesandbox.io/s/admiring-blackwell-y4jlhr?file=/src/demo/DataTableSortDemo.js:243-283

PrimeReact version

8.7.2

React version

17.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

ALL

Steps to reproduce the behavior

  1. Sorting with -1 causes all columns to sort descending.

Expected behavior

nullSortOrder should control sorting properly.
@melloware melloware added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2022
@melloware melloware self-assigned this Nov 28, 2022
@melloware melloware added this to the 8.7.3 milestone Nov 28, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 28, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2022
melloware added a commit to melloware/primereact that referenced this issue Nov 28, 2022
@melloware
Fix primefaces#3712: PrimeReact.nullSortOrder working properly
c03f0cc
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2022
@melloware melloware mentioned this issue Nov 28, 2022
Merged
melloware added a commit that referenced this issue Nov 28, 2022
@melloware
Fix #3712: PrimeReact.nullSortOrder working properly (#3713)
85b5ff9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.3
Development

Successfully merging a pull request may close this issue.

Fix #3712: PrimeReact.nullSortOrder working properly melloware/primereact
1 participant
@melloware