Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3059: ChartJS allow loading by script tag #3061

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

melloware
Copy link
Member

@melloware melloware commented Jul 14, 2022

###Defect Fixes
Fix #3059: ChartJS allow loading by script tag

Dynamically checks and prevents name collision with Chart to allow loading from script.

 <script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/3.8.0/chart.min.js" crossorigin="anonymous"></script>
<script src="https://unpkg.com/primereact/core/core.min.js"></script>
<script src="https://unpkg.com/primereact/chart/chart.min.js" crossorigin="anonymous"></script>

@melloware melloware merged commit b8b2964 into primefaces:master Jul 14, 2022
@melloware melloware deleted the PR3059 branch July 14, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts: Explicit import of chart.js dependency doesn't allow for single pages with inline scripting
1 participant