Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot testing updates #3585

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Snapshot testing updates #3585

merged 1 commit into from
Nov 8, 2022

Conversation

melloware
Copy link
Member

cc @kalinkrustev you are right for PrimeReact Snapshots are the way to go when validating the state of the DOM since anything might change!

@melloware melloware added the Component: Test Issue or pull request is related to Component Testing label Nov 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@bahadirsofuoglu
Copy link
Contributor

Include my ideas about this topic https://github.com/primefaces/primereact/pull/3579/files#r1014629718

@melloware melloware merged commit 5067a14 into primefaces:master Nov 8, 2022
@melloware melloware deleted the snapshot-testing branch November 8, 2022 13:11
@kalinkrustev
Copy link
Contributor

Great, now I can give you some further ideas how to simplify even more some of the tests.

@melloware
Copy link
Member Author

yeah i think any tests you add would be a bonus. Feel free to submit PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@habubey habubey Awaiting requested review from habubey

@bahadirsofuoglu bahadirsofuoglu Awaiting requested review from bahadirsofuoglu

Assignees
No one assigned
Labels
Component: Test Issue or pull request is related to Component Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melloware @bahadirsofuoglu @kalinkrustev