Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: combine the className props in the Menu separator #6884

Merged
merged 1 commit into from
Jul 14, 2024
Merged

fix: combine the className props in the Menu separator #6884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/lib/menu/Menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,13 +319,13 @@ export const Menu = React.memo(
);
};

const createSeparator = (index) => {
const createSeparator = (item, index) => {
const key = idState + '_separator_' + index;
const separatorProps = mergeProps(
{
id: key,
key,
className: cx('separator'),
className: classNames(item.className, cx('separator')),
role: 'separator'
},
ptm('separator')
Expand Down Expand Up @@ -424,7 +424,7 @@ export const Menu = React.memo(
};

const createItem = (item, index) => {
return item.separator ? createSeparator(index) : item.items ? createSubmenu(item, index) : createMenuItem(item, index);
return item.separator ? createSeparator(item, index) : item.items ? createSubmenu(item, index) : createMenuItem(item, index);
};

const createMenu = () => {
Expand Down
Loading