InputNumber: fix formatting of currencies with suffix #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
thielpa
changed the title
|
@tugcekucukoglu Any updates on merging this PR this would be great to finally get fixed |
thielpa
force-pushed
the
fix-currency-euro
branch
from
a009066
to
64579b8
Compare
|
@tugcekucukoglu pinging for visibility, because I think this PR is ready for review. If something should not be right with this PR just let me know, I am happy to make the necessary changes so my work can be merged! Note: I think the unittest fails are not caused by my changes. (I hope my pinging is fine, if not sorry in advance!) |
|
btw shouldn't you write tests, so it would not be lost in the future? |
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you enter a negative number in the InputNumber field (with formatting set to a currency with a suffix), the input becomes doubled (f.e. if you type -1, it becomes -11). This is because there is a missing check if decimalCharIndex is valid or not.
Unfortunately I did not find a solution for writing a test, that covers this bug, because this relies on the keydown event handling of input fields (which vue-test-utils does not support at the time). If you have an idea how to fix this, please let me know, I am happy to write a test for this issue.
Fix #3382