Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulate ACP forum #11

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Tabulate ACP forum #11

merged 5 commits into from
Apr 17, 2020

Conversation

Dark1z
Copy link
Collaborator

@Dark1z Dark1z commented Apr 16, 2020

0

Dark❶ added 3 commits April 16, 2020 12:49
Signed-off-by: Dark❶ <dark-1@users.noreply.github.com>
Signed-off-by: Dark❶ <dark-1@users.noreply.github.com>
Signed-off-by: Dark❶ <dark-1@users.noreply.github.com>
@Dark1z
Copy link
Collaborator Author

Dark1z commented Apr 16, 2020

Done as you asked in Discord 😃

Best regards 👍

primehalo and others added 2 commits April 16, 2020 15:09
Changed the row colors to differentiate categories from forums so that they stand out, especially when in narrow mode where everything is stacked. Merged the Edit column into the Forum Name column to keep focus on the extension settings, especially in narrow mode. Highlighted hovered rows and added tooltip titles displaying the forum name to help make it clear which forum is being manipulated.
This will get the Text of Forum Name to vertically center.

Signed-off-by: Dark❶ <dark-1@users.noreply.github.com>
@Dark1z
Copy link
Collaborator Author

Dark1z commented Apr 17, 2020

I made a small change to forum name column ,
Now the Text will be vertically centered along with the Icon.

I think this PR is ready for merge.

Best regards 👍

@primehalo primehalo merged commit 8bb065b into primehalo:master Apr 17, 2020
@Dark1z Dark1z deleted the tabulate-acp-forum branch April 17, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants